Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to type_repetition_in_bounds #4403

Merged
merged 2 commits into from
Aug 18, 2019
Merged

Improvements to type_repetition_in_bounds #4403

merged 2 commits into from
Aug 18, 2019

Conversation

xd009642
Copy link
Contributor

@xd009642 xd009642 commented Aug 17, 2019 •
edited by flip1995
Loading

Improvements to the type_repetition_in_bounds trait based on feedback from #4380 #4326 #4323

Currently just make it pedantic. Hopefully, more to come

changelog: move type_repetition_in_bounds to pedantic

phansch
phansch approved these changes Aug 17, 2019
View reviewed changes
Copy link
Member

@phansch phansch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! r=me once Clippy works again with rust master

@flip1995
Copy link
Member

You have to run ./utils/dev update_lints

@flip1995 flip1995 added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Aug 18, 2019
@flip1995
Copy link
Member

Thanks!

@bors r=phansch,flip1995

@bors
Copy link
Collaborator

bors commented Aug 18, 2019

📌 Commit 76598ad has been approved by phansch,flip1995

@bors
Copy link
Collaborator

bors commented Aug 18, 2019

⌛ Testing commit 76598ad with merge 2d493ed...

bors added a commit that referenced this pull request Aug 18, 2019
@bors
Auto merge of #4403 - xd009642:type_repetition_improvements, r=phansc…
2d493ed 
…h,flip1995

Improvements to `type_repetition_in_bounds`

Improvements to the `type_repetition_in_bounds` trait based on feedback from #4380 #4326 #4323

Currently just make it pedantic. Hopefully, more to come
@bors
Copy link
Collaborator

bors commented Aug 18, 2019

💔 Test failed - checks-travis

@flip1995
Copy link
Member

@bors retry

@bors
Copy link
Collaborator

bors commented Aug 18, 2019

⌛ Testing commit 76598ad with merge f01a0c0...

bors added a commit that referenced this pull request Aug 18, 2019
@bors
Auto merge of #4403 - xd009642:type_repetition_improvements, r=phansc…
f01a0c0 
…h,flip1995

Improvements to `type_repetition_in_bounds`

Improvements to the `type_repetition_in_bounds` trait based on feedback from #4380 #4326 #4323

Currently just make it pedantic. Hopefully, more to come

changelog: move `type_repetition_in_bounds` to `pedantic`
@bors
Copy link
Collaborator

bors commented Aug 18, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch,flip1995
Pushing f01a0c0 to master...

@bors bors merged commit 76598ad into rust-lang:master Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansch phansch phansch approved these changes

Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xd009642 @flip1995 @bors @phansch