Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix match_as_ref bad suggestion #4446

Merged
merged 2 commits into from Aug 30, 2019
Merged

Fix match_as_ref bad suggestion #4446

merged 2 commits into from Aug 30, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 25, 2019

Fixes #4437

changelog: Fix match_as_ref bad suggestion

@phansch phansch added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 25, 2019
@phansch phansch self-requested a review August 30, 2019 06:05
@phansch
Copy link
Member

phansch commented Aug 30, 2019

@bors r+ thanks!

@bors
Copy link
Collaborator

bors commented Aug 30, 2019

📌 Commit 0c83325 has been approved by phansch

@bors
Copy link
Collaborator

bors commented Aug 30, 2019

⌛ Testing commit 0c83325 with merge 2bff3d8...

bors added a commit that referenced this pull request Aug 30, 2019
Fix `match_as_ref` bad suggestion

Fixes #4437

changelog: Fix `match_as_ref` bad suggestion
@bors
Copy link
Collaborator

bors commented Aug 30, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing 2bff3d8 to master...

@bors bors merged commit 0c83325 into rust-lang:master Aug 30, 2019
@ghost ghost deleted the fix-4437 branch August 31, 2019 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion of match_as_ref does not compile
2 participants