Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in case of proc-macro attribute expansion #4510

Merged
merged 2 commits into from
Sep 9, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Sep 6, 2019

cc #4507
changelog: none
r? @flip1995

@tesuji tesuji force-pushed the unsep-literals-regression-macro-attr branch from 79bbf39 to aaa7e01 Compare September 7, 2019 04:01
@tesuji
Copy link
Contributor Author

tesuji commented Sep 7, 2019

I added the regression test. Thanks for your mentoring @flip1995 :)

@tesuji tesuji force-pushed the unsep-literals-regression-macro-attr branch 4 times, most recently from 21ea38f to ca1c0aa Compare September 9, 2019 09:14
@flip1995
Copy link
Member

flip1995 commented Sep 9, 2019

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 9, 2019

📌 Commit ca1c0aa has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Sep 9, 2019

⌛ Testing commit ca1c0aa with merge 144d940...

bors added a commit that referenced this pull request Sep 9, 2019
…flip1995

Fix regression in case of proc-macro attribute expansion

cc  #4507
changelog: none
r? @flip1995
@bors
Copy link
Collaborator

bors commented Sep 9, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 144d940 to master...

@bors bors merged commit ca1c0aa into rust-lang:master Sep 9, 2019
@tesuji tesuji deleted the unsep-literals-regression-macro-attr branch September 9, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants