Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustup to https://github.com/rust-lang/rust/pull/64746 #4572

Closed
wants to merge 1 commit into from

Conversation

phansch
Copy link
Member

@phansch phansch commented Sep 25, 2019

changelog: none

@phansch phansch changed the title Rust up to https://github.com/rust-lang/rust/pull/64746 Rustup to https://github.com/rust-lang/rust/pull/64746 Sep 25, 2019
@flip1995
Copy link
Member

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Sep 25, 2019

📌 Commit d0b1660 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Sep 25, 2019

⌛ Testing commit d0b1660 with merge f59209c...

bors added a commit that referenced this pull request Sep 25, 2019
@bors
Copy link
Collaborator

bors commented Sep 25, 2019

💔 Test failed - checks-travis

@phansch
Copy link
Member Author

phansch commented Sep 25, 2019

Looks like we're running into rust-lang/cargo#7427

@Manishearth
Copy link
Member

This isn't the correct rustup, we should add a type annotation so that the error isn't hit at all.

We should avoid hitting compiler errors in tests, otherwise they tend to exit before some of their things get tested 😄

@Manishearth
Copy link
Member

#4574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants