Fix ICE #4579 #4590
Fix ICE #4579 #4590
Conversation
flip1995
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #4591) made this pull request unmergeable. Please resolve the merge conflicts. |
flip1995
force-pushed
the
ice_4579
branch
2 times, most recently
from
30eaee0
to
d8a9d6e
Compare
|
@bors r+ |
|
📌 Commit d8a9d6e has been approved by |
|
💔 Test failed - status-appveyor |
|
@bors retryr |
|
@bors retry (good morning 🌅 ) |
|
💔 Test failed - checks-travis |
|
needs a rebase, then it should be good to go |
phansch
added
S-waiting-on-author
|
Integration tests won't pass because of Rust bug. |
|
Feel free to mark those as allowed fail, I don't think that rust bug is
going to be fixed within the next few days, seems tricky.
…On Tue, Oct 1, 2019, 11:56 PM Mateusz Mikuła ***@***.***> wrote:
Integration tests won't pass because of Rust bug.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4590?email_source=notifications&email_token=AAMK6SDR5ZPOH3VHZWBBCNLQMRA2XA5CNFSM4I3GR57KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEADYDNI#issuecomment-537362869>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMK6SFICHATUS7MJPLYREDQMRA2XANCNFSM4I3GR57A>
.
|
|
Rebased seemed to be enough @bors r=Manishearth |
|
📌 Commit 93bda48 has been approved by |
|
💔 Test failed - checks-travis |
Ups should have read the comments more carefully 😄 @bors r=Manishearth |
|
📌 Commit eb1fc7b has been approved by |
|
☀️ Test successful - checks-travis, status-appveyor |
[Beta] Backport Clippy ICE fix to beta There was an ICE in Clippy, when compiling `mysql_common`. Since this is a pretty popular crate, and there were a bunch of Clippy issues in the last few days, I think it is worth it to backport the fix (rust-lang/rust-clippy#4590) to beta. cc rust-lang/rust-clippy#4653 r? @Manishearth
Fixes #4579
Fixes #4584
r? @phansch
changelog: Fix ICE caused by Clippys const-utils