Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Workaround cargo bug on Windows" #4641

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

sinkuu
Copy link
Contributor

@sinkuu sinkuu commented Oct 8, 2019

Cargo is fixed on rust master. This reverts PR #4624.

Fixes #4638

changelog: none

This reverts commit 248251b.
This reverts commit 20b7351.
@phansch
Copy link
Member

phansch commented Oct 8, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 8, 2019

📌 Commit d2daf8e has been approved by phansch

@bors
Copy link
Collaborator

bors commented Oct 8, 2019

🌲 The tree is currently closed for pull requests below priority 10, this pull request will be tested once the tree is reopened

@phansch

This comment has been minimized.

@phansch

This comment has been minimized.

@phansch

This comment has been minimized.

@phansch
Copy link
Member

phansch commented Oct 8, 2019

Sorry for the noise. It seems it just took a few minutes for bors to re-open the tree. #4592 just started, so this PR should be testing soon.

bors added a commit that referenced this pull request Oct 8, 2019
Revert "Workaround cargo bug on Windows"

[Cargo is fixed on rust master](rust-lang/rust#65186). This reverts PR #4624.

Fixes #4638

changelog: none
@bors
Copy link
Collaborator

bors commented Oct 8, 2019

⌛ Testing commit d2daf8e with merge 5cb9833...

@bors
Copy link
Collaborator

bors commented Oct 8, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing 5cb9833 to master...

@bors bors merged commit d2daf8e into rust-lang:master Oct 8, 2019
@sinkuu sinkuu deleted the revert_workaround branch October 8, 2019 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

./util/dev fmt fails
3 participants