Add inefficient_to_string lint
#4683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansch
added
the
S-waiting-on-review
flip1995
approved these changes
Oct 17, 2019
| @@ -0,0 +1,31 @@ | |||
| #![deny(clippy::inefficient_to_string)] | |||
There was a problem hiding this comment.
Can you add // run-rustfix to make this a rustfix test?
flip1995
added
S-waiting-on-author
HMPerson1
force-pushed
the
inefficient_to_string
branch
from
0674d01
to
ffb53e7
Compare
Manishearth
approved these changes
Oct 17, 2019
|
(You'll also need to update the test expectations) |
Co-Authored-By: Manish Goregaokar <manishsmail@gmail.com>
HMPerson1
force-pushed
the
inefficient_to_string
branch
from
82dbeb3
to
2106a23
Compare
|
@bors r+ thanks! |
|
📌 Commit 2106a23 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 17, 2019
Add `inefficient_to_string` lint Closes #4586 changelog: Add `inefficient_to_string` lint, which checks for calling `to_string` on `&&str`, which would bypass the `str`'s specialization
|
☀️ Test successful - checks-travis, status-appveyor |
This was referenced Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4586
changelog: Add
inefficient_to_stringlint, which checks for callingto_stringon&&str, which would bypass thestr's specialization