Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emit try_err lint in external macros #4721

Merged
merged 1 commit into from Oct 24, 2019

Conversation

@phansch
Copy link
Member

phansch commented Oct 24, 2019

changelog: Fix [try_err] false positive in external macros

Closes #4709

@flip1995

This comment has been minimized.

Copy link
Member

flip1995 commented Oct 24, 2019

@bors r+

Thanks!

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 24, 2019

📌 Commit 52f5290 has been approved by flip1995

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 24, 2019

🌲 The tree is currently closed for pull requests below priority 10, this pull request will be tested once the tree is reopened

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 24, 2019

⌛️ Testing commit 52f5290 with merge bfef48f...

bors added a commit that referenced this pull request Oct 24, 2019
Don't emit try_err lint in external macros

changelog: Fix [`try_err`] false positive in external macros

Closes #4709
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 24, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing bfef48f to master...

@bors bors merged commit 52f5290 into rust-lang:master Oct 24, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@EverlastingBugstopper

This comment has been minimized.

Copy link

EverlastingBugstopper commented Oct 24, 2019

Yay!!! Thanks so much @phansch!

@phansch phansch deleted the phansch:fix_try_err_in_ext_macro branch Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.