Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emit try_err lint in external macros #4721

Merged
merged 1 commit into from Oct 24, 2019

Conversation

phansch
Copy link
Member

@phansch phansch commented Oct 24, 2019

changelog: Fix [try_err] false positive in external macros

Closes #4709

@phansch phansch added the S-waiting-on-review label Oct 24, 2019
@flip1995
Copy link
Member

@flip1995 flip1995 commented Oct 24, 2019

@bors r+

Thanks!

@bors
Copy link
Contributor

@bors bors commented Oct 24, 2019

📌 Commit 52f5290 has been approved by flip1995

@bors
Copy link
Contributor

@bors bors commented Oct 24, 2019

🌲 The tree is currently closed for pull requests below priority 10, this pull request will be tested once the tree is reopened

@bors
Copy link
Contributor

@bors bors commented Oct 24, 2019

Testing commit 52f5290 with merge bfef48f...

bors added a commit that referenced this issue Oct 24, 2019
Don't emit try_err lint in external macros

changelog: Fix [`try_err`] false positive in external macros

Closes #4709
@bors
Copy link
Contributor

@bors bors commented Oct 24, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing bfef48f to master...

@bors bors merged commit 52f5290 into rust-lang:master Oct 24, 2019
2 checks passed
@EverlastingBugstopper
Copy link

@EverlastingBugstopper EverlastingBugstopper commented Oct 24, 2019

Yay!!! Thanks so much @phansch!

@phansch phansch deleted the fix_try_err_in_ext_macro branch Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants