trigger string_lit_as_bytes when literal has escapes #4808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
added
the
S-blocked
euclio
force-pushed
the
string-lit-as-bytes
branch
from
28eeae7
to
bad1624
Compare
|
@flip1995 This is now unblocked. |
phansch
approved these changes
Nov 18, 2019
phansch
removed
the
S-blocked
flip1995
added
the
S-waiting-on-review
|
@bors r=phansch rollup |
1 similar comment
|
@bors r=phansch rollup |
|
bors lost this PR. Once the pile from the rustup is merged, we have to resync the bors queue. |
|
ping @euclio. This PR only needs a rebase. |
euclio
force-pushed
the
string-lit-as-bytes
branch
from
bad1624
to
d33ad45
Compare
|
Rebased, but it won't work until the rustup goes through. |
flip1995
added
S-waiting-on-bors
flip1995
approved these changes
Nov 27, 2019
|
@bors r+ |
|
📌 Commit d33ad45 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 28, 2019
trigger string_lit_as_bytes when literal has escapes --- changelog: fix string_lit_as_bytes false negative Depends on rust-lang/rust#66349. Fixes #4796.
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: fix string_lit_as_bytes false negative
Depends on rust-lang/rust#66349.
Fixes #4796.