Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some positive examples to lint docs #4832

Merged
merged 2 commits into from
Nov 28, 2019
Merged

Add some positive examples to lint docs #4832

merged 2 commits into from
Nov 28, 2019

Conversation

dario23
Copy link
Contributor

@dario23 dario23 commented Nov 19, 2019

fixes #4829
changelog: Add some positive examples to lint docs

@dario23
Copy link
Contributor Author

dario23 commented Nov 19, 2019

note: not sure about the intention in the original bug report; but i'll probably comb through the lints some more to add good examples to more lints.

@flip1995 flip1995 added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Nov 20, 2019
flip1995
flip1995 approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Marking this as waiting-on-author. If you're done with adding examples in this PR, let me know!

@flip1995 flip1995 added S-waiting-on-bors Status: The marked PR was approved and is only waiting bors and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Nov 25, 2019
@phansch
Copy link
Member

phansch commented Nov 28, 2019

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 28, 2019

📌 Commit c6e6b29 has been approved by phansch

phansch added a commit to phansch/rust-clippy that referenced this pull request Nov 28, 2019
@phansch
Rollup merge of rust-lang#4832 - dario23:i4829, r=phansch
6686892 
Add some positive examples to lint docs

fixes rust-lang#4829
changelog: Add some positive examples to lint docs
@phansch phansch mentioned this pull request Nov 28, 2019
Merged
bors added a commit that referenced this pull request Nov 28, 2019
@bors
Auto merge of #4855 - phansch:rollup-x7yail7, r=phansch
dbdd75a 
Rollup of 3 pull requests

Successful merges:

 - #4832 (Add some positive examples to lint docs)
 - #4842 ([comparison_chain] #4827 Check `core::cmp::Ord` is implemented)
 - #4847 (fixing a typo)

Failed merges:

changelog: none

r? @ghost
@bors
Copy link
Collaborator

bors commented Nov 28, 2019

⌛ Testing commit c6e6b29 with merge dbdd75a...

@bors bors merged commit c6e6b29 into rust-lang:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 approved these changes

Assignees
No one assigned
Labels
S-waiting-on-bors Status: The marked PR was approved and is only waiting bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Give "corrected" code in examples
4 participants
@dario23 @phansch @bors @flip1995