Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move use_self to nursery #4863

Merged
merged 2 commits into from Nov 29, 2019
Merged

Move use_self to nursery #4863

merged 2 commits into from Nov 29, 2019

Conversation

@phansch
Copy link
Member

phansch commented Nov 29, 2019

Closes #4859

We have a lot of false positives in this lint, so I think it makes sense
to move this to the nursery until they are resolved.

changelog: Move use_self lint to nursery, due to many false positives

Closes #4859

We have a lot of false positives in this lint, so I think it makes sense
to move this to the nursery until they are resolved.

changelog: Move `use_self` lint to nursery, due to many false positives
@flip1995

This comment has been minimized.

Copy link
Member

flip1995 commented Nov 29, 2019

update_lints should have updated clippy_lints/src/lib.rs too.

@phansch

This comment has been minimized.

Copy link
Member Author

phansch commented Nov 29, 2019

Huh, indeed. Not at my Clippy machine right now but I will check later today. Maybe I just forgot to commit that file.

@flip1995

This comment has been minimized.

Copy link
Member

flip1995 commented Nov 29, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 29, 2019

📌 Commit fd7eca2 has been approved by flip1995

bors added a commit that referenced this pull request Nov 29, 2019
Move use_self to nursery

Closes #4859

We have a lot of false positives in this lint, so I think it makes sense
to move this to the nursery until they are resolved.

changelog: Move `use_self` lint to nursery, due to many false positives
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 29, 2019

⌛️ Testing commit fd7eca2 with merge 5de93cc...

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 29, 2019

💔 Test failed - checks-travis

@phansch

This comment has been minimized.

Copy link
Member Author

phansch commented Nov 29, 2019

It looks like something's wrong with the changelog: detection:

KeyError: 'body'
ERROR: PR body must (cut off)

If there's no body key in the response, it's probably an error response.

@phansch

This comment has been minimized.

Copy link
Member Author

phansch commented Nov 29, 2019

@bors retry - maybe it was a temporary issue

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 29, 2019

⌛️ Testing commit fd7eca2 with merge 0403687...

bors added a commit that referenced this pull request Nov 29, 2019
Move use_self to nursery

Closes #4859

We have a lot of false positives in this lint, so I think it makes sense
to move this to the nursery until they are resolved.

changelog: Move `use_self` lint to nursery, due to many false positives
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 29, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 0403687 to master...

@bors bors merged commit fd7eca2 into rust-lang:master Nov 29, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.