Fix false positive with cast_sign_loss lint #4883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cast_sign_loss` lint incorrectly suggests that the result of `checked_abs`, `rem_euclid` and `checked_rem_euclid` cannot be casted to an unsigned integer without loss.
flip1995
added
the
S-waiting-on-author
krishna-veerareddy
changed the title
|
Does this also work with type widening, such as Other than that question, looks good to me. |
|
@jhpratt It allows widening as well. Should I add test cases for that as well? |
|
It certainly wouldn't hurt! |
|
Should I add test cases for all the sized types or just one for u8 -> u16 widening? |
|
@flip1995 Please review when you have some time. |
|
Sorry, was absent for the past few days. Can be merged as is, awesome! 🎉 @bors r+ |
|
📌 Commit c0fb74b has been approved by |
bors
added a commit
that referenced
this pull request
Dec 12, 2019
…lse-positive, r=flip1995 Fix false positive with cast_sign_loss lint `cast_sign_loss` lint incorrectly suggests that the result of `checked_abs`, `rem_euclid` and `checked_rem_euclid` cannot be casted to an unsigned integer without loss. Fixes #4818 #4764 #4743 changelog: Fix false positives in `cast_sign_loss` lint
|
☀️ Test successful - checks-travis, status-appveyor |
krishna-veerareddy
deleted the
issue-4818-cast-sign-loss-false-positive
branch
|
@flip1995 No worries. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cast_sign_losslint incorrectly suggests that the result ofchecked_abs,rem_euclidandchecked_rem_euclidcannot be casted to an unsigned integer without loss.Fixes #4818 #4764 #4743
changelog: Fix false positives in
cast_sign_losslint