Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix useless_attribute suggestion #5022

Merged
merged 2 commits into from
Jan 8, 2020
Merged

Conversation

flip1995
Copy link
Member

@flip1995 flip1995 commented Jan 8, 2020

Fixes #5021

changelog: Fix [useless_attribute] suggestion, which tripped rustfix

@flip1995 flip1995 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 8, 2020
@phansch
Copy link
Member

phansch commented Jan 8, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 8, 2020

📌 Commit 6eba665 has been approved by phansch

@bors
Copy link
Collaborator

bors commented Jan 8, 2020

⌛ Testing commit 6eba665 with merge a4e1388...

bors added a commit that referenced this pull request Jan 8, 2020
Fix useless_attribute suggestion

Fixes #5021

changelog: Fix [`useless_attribute`] suggestion, which tripped rustfix
@bors
Copy link
Collaborator

bors commented Jan 8, 2020

💔 Test failed - checks-travis

@phansch
Copy link
Member

phansch commented Jan 8, 2020

@bors retry (spurious network error)

@bors
Copy link
Collaborator

bors commented Jan 8, 2020

⌛ Testing commit 6eba665 with merge 0da0ae3...

bors added a commit that referenced this pull request Jan 8, 2020
Fix useless_attribute suggestion

Fixes #5021

changelog: Fix [`useless_attribute`] suggestion, which tripped rustfix
@bors
Copy link
Collaborator

bors commented Jan 8, 2020

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing 0da0ae3 to master...

@bors bors merged commit 6eba665 into rust-lang:master Jan 8, 2020
@flip1995 flip1995 deleted the useless_attr branch January 8, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion of useless_attribute breaks rustfix
3 participants