Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable let_underscore_must_use in external macros #5082

Merged
merged 1 commit into from
Jan 23, 2020
Merged

disable let_underscore_must_use in external macros #5082

merged 1 commit into from
Jan 23, 2020

Conversation

basil-cow
Copy link
Contributor

changelog: disable let_underscore_must_use in external macros
Closes #4980

@flip1995
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 23, 2020

📌 Commit 98a49b5 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Jan 23, 2020

⌛ Testing commit 98a49b5 with merge 951aed8...

bors added a commit that referenced this pull request Jan 23, 2020
@bors
Auto merge of #5082 - Areredify:issue-4980, r=flip1995
951aed8 
disable let_underscore_must_use in external macros

changelog: disable let_underscore_must_use in external macros
Closes #4980
@flip1995
Copy link
Member

@bors r- retry

@flip1995
Copy link
Member

Can you add a test? This should just be

#[derive(Debug)]
struct Foo {
    field: i32,
}

r=me with test added.

@basil-cow
Copy link
Contributor Author

@bors r=flip1995

@bors
Copy link
Collaborator

bors commented Jan 23, 2020

@Areredify: 🔑 Insufficient privileges: Not in reviewers

@flip1995
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 23, 2020

📌 Commit fef3657 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Jan 23, 2020

⌛ Testing commit fef3657 with merge 3237b7a...

bors added a commit that referenced this pull request Jan 23, 2020
@bors
Auto merge of #5082 - Areredify:issue-4980, r=flip1995
3237b7a 
disable let_underscore_must_use in external macros

changelog: disable let_underscore_must_use in external macros
Closes #4980
@bors
Copy link
Collaborator

bors commented Jan 23, 2020

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 3237b7a to master...

@bors bors merged commit fef3657 into rust-lang:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

let-underscore-must-use is triggered when Debug is derived
3 participants
@basil-cow @flip1995 @bors