Move check for lossy whole-number floats out of excessive_precision
#5202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
reviewed
Feb 20, 2020
krishna-veerareddy
force-pushed
the
issue-5201-move-lossy-float-literal-restriction
branch
from
f2a486b
to
c25f1ea
Compare
krishna-veerareddy
force-pushed
the
issue-5201-move-lossy-float-literal-restriction
branch
from
c25f1ea
to
219c94d
Compare
|
@bors r+ |
|
📌 Commit 219c94d has been approved by |
bors
added a commit
that referenced
this pull request
Feb 21, 2020
…literal-restriction, r=flip1995 Move check for lossy whole-number floats out of `excessive_precision` changelog: Add new lint `lossy_float_literal` to detect lossy whole number float literals and move it out of `excessive_precision` again. Fixes #5201
|
💔 Test failed - checks-action_test |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Feb 21, 2020
…literal-restriction, r=flip1995 Move check for lossy whole-number floats out of `excessive_precision` changelog: Add new lint `lossy_float_literal` to detect lossy whole number float literals and move it out of `excessive_precision` again. Fixes #5201
|
💔 Test failed - checks-action_test |
|
@bors retry (MacOS toolchain download...) |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Add new lint
lossy_float_literalto detect lossy whole number float literals and move it out ofexcessive_precisionagain.Fixes #5201