Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint if let Some and early return in question_mark lint #5266

Merged
merged 3 commits into from
Mar 4, 2020
Merged

Lint if let Some and early return in question_mark lint #5266

merged 3 commits into from
Mar 4, 2020

Conversation

sinkuu
Copy link
Contributor

@sinkuu sinkuu commented Mar 4, 2020

Fixes #5260

changelog: lint if let Some and early return in question_mark lint

flip1995
flip1995 reviewed Mar 4, 2020
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

clippy_lints/src/question_mark.rs Outdated Show resolved Hide resolved
@sinkuu @flip1995
Apply suggestions from code review
a78a1fc 
Co-Authored-By: Philipp Krones <hello@philkrones.com>
@flip1995
Copy link
Member

flip1995 commented Mar 4, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 4, 2020

📌 Commit a78a1fc has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Mar 4, 2020

⌛ Testing commit a78a1fc with merge 8c7b3ad...

@bors
Copy link
Collaborator

bors commented Mar 4, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 8c7b3ad to master...

@bors bors merged commit 8c7b3ad into rust-lang:master Mar 4, 2020
@sinkuu sinkuu deleted the questionmark branch March 4, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FN question_mark: if let binding
3 participants
@sinkuu @flip1995 @bors