Improve placeholder in map_unit_fn #5292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
☔ The latest upstream changes (presumably #5290) made this pull request unmergeable. Please resolve the merge conflicts. |
flip1995
approved these changes
Mar 9, 2020
flip1995
added
the
S-waiting-on-author
jpospychala
force-pushed
the
map-placeholder
branch
from
b4eabbb
to
ffc9615
Compare
jpospychala
force-pushed
the
map-placeholder
branch
from
ffc9615
to
697e3c8
Compare
|
@bors r+ Thanks! |
|
📌 Commit 697e3c8 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using
_as a default placeholder usea.fixes #5180
changelog: Improve default placeholder in map_unit_fn