Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint for pub(crate) items that are not crate visible due to the visibility of the module that contains them #5319

Merged
merged 3 commits into from
Mar 23, 2020
Merged

Lint for pub(crate) items that are not crate visible due to the visibility of the module that contains them #5319

merged 3 commits into from
Mar 23, 2020

Conversation

1tgr
Copy link
Contributor

@1tgr 1tgr commented Mar 15, 2020

changelog: Add redundant_pub_crate lint

Closes #5274.

flip1995
flip1995 requested changes Mar 18, 2020
View reviewed changes
clippy_lints/src/redundant_pub_crate.rs Outdated Show resolved Hide resolved
clippy_lints/src/redundant_pub_crate.rs Outdated Show resolved Hide resolved
@flip1995 flip1995 added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Mar 18, 2020
@1tgr 1tgr requested a review from flip1995 March 21, 2020 11:52
flip1995
flip1995 approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. The lint should be enabled by default IMO though.

clippy_lints/src/redundant_pub_crate.rs Outdated
/// }
/// ```
pub REDUNDANT_PUB_CRATE,
nursery,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can put it in the style group.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to run cargo dev update_lints after changing the group.

@flip1995
Copy link
Member

You have to allow this lint in tests/ui/wildcard_imports.rs

@flip1995
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 23, 2020

📌 Commit 870b9e8 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Mar 23, 2020

⌛ Testing commit 870b9e8 with merge d3989ee...

@bors
Copy link
Collaborator

bors commented Mar 23, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing d3989ee to master...

@bors bors merged commit d3989ee into rust-lang:master Mar 23, 2020
This was referenced Mar 23, 2020
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 approved these changes

Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lint on pub(crate) inside private mod
3 participants
@1tgr @flip1995 @bors