unused_self false positive
#5387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
📌 Commit 82f929c has been approved by |
bors
added a commit
that referenced
this pull request
Mar 30, 2020
`unused_self` false positive fixes #5351 Remove the for loop in `unused_self` so that lint enabled for one method doesn't trigger on another method.
|
💔 Test failed - checks-action_test |
|
@bors r=Yaahc , actually |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 82f929c has been approved by |
bors
added a commit
that referenced
this pull request
Mar 30, 2020
`unused_self` false positive fixes #5351 Remove the for loop in `unused_self` so that lint enabled for one method doesn't trigger on another method.
|
💔 Test failed - checks-action_test |
|
@bors r=yaahc (the PR body needed a changelog entry) |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 82f929c has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5351
Remove the for loop in
unused_selfso that lint enabled for one method doesn't trigger on another method.changelog: Fix false positive in
unused_selfaround lint gates on impl items