Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docs for option_option #5403

Merged
merged 4 commits into from
Apr 2, 2020
Merged

Improve docs for option_option #5403

merged 4 commits into from
Apr 2, 2020

Conversation

farnz
Copy link
Contributor

@farnz farnz commented Apr 2, 2020

Hint about using tri-state enums to replace legitimate uses of Option<Option<_>>

changelog: The docs for option_option now suggest using a tri-state enum

@farnz
Improve docs for option_option
db3423f 
Hint about using tri-state enums to replace legitimate uses of `Option<Option<_>>`
flip1995
flip1995 reviewed Apr 2, 2020
View reviewed changes
clippy_lints/src/types.rs Outdated Show resolved Hide resolved
@flip1995 flip1995 added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Apr 2, 2020
flip1995
flip1995 reviewed Apr 2, 2020
View reviewed changes
clippy_lints/src/types.rs Outdated Show resolved Hide resolved
@farnz @flip1995
Update clippy_lints/src/types.rs
5f8b696 
Co-Authored-By: Philipp Krones <hello@philkrones.com>
flip1995
flip1995 approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for CI to pass.

@flip1995 flip1995 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Apr 2, 2020
@flip1995
Copy link
Member

flip1995 commented Apr 2, 2020

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Apr 2, 2020

📌 Commit 5f8b696 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Apr 2, 2020

⌛ Testing commit 5f8b696 with merge 949a5ba...

@bors
Copy link
Collaborator

bors commented Apr 2, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 949a5ba to master...

@bors bors merged commit 949a5ba into rust-lang:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995 flip1995 approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@farnz @flip1995 @bors