Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for new_ret_no_self #5448

Merged
merged 2 commits into from
Apr 13, 2020
Merged

Update documentation for new_ret_no_self #5448

merged 2 commits into from
Apr 13, 2020

Conversation

Emerentius
Copy link
Contributor

changelog: Update documentation for lint new_ret_no_self to reflect that the return type must only contain Self, not be Self

The lint was changed to be more lenient than the documentation implies in PR #3338 (Related issue #3313)

@Emerentius
Update documentation for new_ret_no_self
ed72dc4 
The lint was changed to be more lenient than the documentation implies in PR rust-lang#3338.
Related issue rust-lang#3313
@Emerentius
Copy link
Contributor Author

Dunno about Clippy Dev Test / clippy_dev (pull_request) but the errors in Clippy Test / base (pull_request) seem unrelated.

@phansch phansch added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 12, 2020
@phansch
Copy link
Member

phansch commented Apr 12, 2020

Going to trigger a new build, then it should be green :)

@phansch phansch closed this Apr 12, 2020
@phansch phansch reopened this Apr 12, 2020
@phansch
Copy link
Member

phansch commented Apr 12, 2020

@Emerentius you'll also need to run clippy dev update_lints for the lint description change to be registered

@phansch phansch added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Apr 12, 2020
@Emerentius
Copy link
Contributor Author

Done.

Also, wow, you need to download and compile a lot of stuff for this dev tool.

@phansch
Copy link
Member

phansch commented Apr 13, 2020

Also, wow, you need to download and compile a lot of stuff for this dev tool.

Yeah, that's mostly due to using clap and regex

@bors r+ thanks!

@bors
Copy link
Collaborator

bors commented Apr 13, 2020

📌 Commit e98c7a4 has been approved by phansch

@phansch phansch removed the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Apr 13, 2020
bors added a commit that referenced this pull request Apr 13, 2020
@bors
Auto merge of #5448 - Emerentius:update_new_ret_no_self_docs, r=phansch
c9250fb 
Update documentation for new_ret_no_self

changelog: Update documentation for lint new_ret_no_self to reflect that the return type must only contain `Self`, not be `Self`

The lint was changed to be more lenient than the documentation implies in PR #3338 (Related issue #3313)
@bors
Copy link
Collaborator

bors commented Apr 13, 2020

⌛ Testing commit e98c7a4 with merge c9250fb...

@bors
Copy link
Collaborator

bors commented Apr 13, 2020

💔 Test failed - checks-action_test

@phansch
Copy link
Member

phansch commented Apr 13, 2020

(The failure is unrelated to your PR, likely caused by rust-lang/rust#71029)

@phansch phansch added the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work label Apr 13, 2020
@phansch phansch removed the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work label Apr 13, 2020
@phansch
Copy link
Member

phansch commented Apr 13, 2020

@bors retry

@bors
Copy link
Collaborator

bors commented Apr 13, 2020

⌛ Testing commit e98c7a4 with merge 54344c7...

@bors
Copy link
Collaborator

bors commented Apr 13, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: phansch
Pushing 54344c7 to master...

@bors bors merged commit 54344c7 into rust-lang:master Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansch phansch phansch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Emerentius @phansch @bors