Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Use our sym! macro more #5457

Merged
merged 1 commit into from Apr 14, 2020
Merged

Cleanup: Use our sym! macro more #5457

merged 1 commit into from Apr 14, 2020

Conversation

phansch
Copy link
Member

@phansch phansch commented Apr 13, 2020

It's much shorter than Symbol::intern and the effect should still be clear


changelog: none

It's much shorter that Symbol::intern and the result should still be
clear.
@phansch phansch added the S-waiting-on-review label Apr 13, 2020
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Apr 14, 2020

Cool!
@bors r+

@bors
Copy link
Contributor

bors commented Apr 14, 2020

📌 Commit 31c5664 has been approved by matthiaskrgr

@bors
Copy link
Contributor

bors commented Apr 14, 2020

Testing commit 31c5664 with merge 519b87c...

bors added a commit that referenced this issue Apr 14, 2020
Cleanup: Use our `sym!` macro more

It's much shorter than Symbol::intern and the effect should still be clear

---

changelog: none
@bors
Copy link
Contributor

bors commented Apr 14, 2020

💔 Test failed - checks-action_test

@matthiaskrgr
Copy link
Member

matthiaskrgr commented Apr 14, 2020

Needs rustup, working on it.

@phansch
Copy link
Member Author

phansch commented Apr 14, 2020

@bors retry

@bors
Copy link
Contributor

bors commented Apr 14, 2020

Testing commit 31c5664 with merge d236b30...

@bors
Copy link
Contributor

bors commented Apr 14, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: matthiaskrgr
Pushing d236b30 to master...

@bors bors merged commit d236b30 into rust-lang:master Apr 14, 2020
5 checks passed
@phansch phansch deleted the sym branch Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants