Fix unnecessary_unwrap lint when checks are done in parameters
#5558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThibsG
changed the title
ThibsG
changed the title
unnecessary_unwrap lint when checks are done in parameters
phansch
added
the
S-waiting-on-review
|
What an awesome fix, thanks! @bors r+ |
|
📌 Commit 72ce6d5 has been approved by |
bors
added a commit
that referenced
this pull request
May 2, 2020
Fix `unnecessary_unwrap` lint when checks are done in parameters Fixes a false positive in `unnecessary_unwrap` lint when checks are done in macro parameters. FIxes #5174 changelog: Fixes a false positive in `unnecessary_unwrap` lint when checks are done in macro parameters.
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward |
|
@bors retry |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a false positive in
unnecessary_unwraplint when checks are done in macro parameters.FIxes #5174
changelog: Fixes a false positive in
unnecessary_unwraplint when checks are done in macro parameters.