Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple_crate_versions: skip dev and build deps #5636

Merged
merged 3 commits into from May 26, 2020
Merged

multiple_crate_versions: skip dev and build deps #5636

merged 3 commits into from May 26, 2020

Conversation

ebroto
Copy link
Member

@ebroto ebroto commented May 22, 2020 •
edited

changelog: multiple_crate_versions: skip dev and build deps

Closes #5041

@phansch phansch added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 23, 2020
@phansch phansch added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) S-waiting-on-bors Status: The marked PR was approved and is only waiting bors and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels May 24, 2020
phansch
phansch approved these changes May 24, 2020
View reviewed changes
Copy link
Member

@phansch phansch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@flip1995
Copy link
Member

@bors r=phansch

@bors
Copy link
Collaborator

bors commented May 25, 2020

📌 Commit 7141d60 has been approved by phansch

@phansch
Copy link
Member

phansch commented May 26, 2020

@bors retry

@phansch
Copy link
Member

phansch commented May 26, 2020

Ah that should have been

@bors r+

@bors
Copy link
Collaborator

bors commented May 26, 2020

📌 Commit ec0a00e has been approved by phansch

@bors
Copy link
Collaborator

bors commented May 26, 2020

⌛ Testing commit ec0a00e with merge 182ac89...

@bors
Copy link
Collaborator

bors commented May 26, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: phansch
Pushing 182ac89 to master...

@bors bors merged commit 182ac89 into rust-lang:master May 26, 2020
@ebroto ebroto deleted the issue_5041 branch May 26, 2020 07:04
@ebroto ebroto mentioned this pull request May 26, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansch phansch phansch approved these changes

Assignees

@phansch phansch

Labels
S-waiting-on-bors Status: The marked PR was approved and is only waiting bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

multiple_crate_versions lint detects dev dependencies also
4 participants
@ebroto @flip1995 @bors @phansch