Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix remaining lint messages #5893

Merged
merged 13 commits into from
Aug 12, 2020
Merged

fix remaining lint messages #5893

merged 13 commits into from
Aug 12, 2020

Conversation

matthiaskrgr
Copy link
Member

r? @yaahc

changelog: make remaining lint messages adhere to rustc dev guide lint message convention.

@matthiaskrgr
stable-sort-primitive: make lint adhere to lint message convention
c0a9d64
@matthiaskrgr
map_clone: make lint adhere to lint message convention
ac194ca
@matthiaskrgr
mutex-atomic: make lint adhere to lint message convention
04867e0
@matthiaskrgr
iter-next-slice: make lint adhere to lint message convention
6af297f
@matthiaskrgr
int_plus_one: make lint adhere to lint message convention
f171f89
@matthiaskrgr
implicit-saturating-sub: make lint adhere to lint message convention
bdf4dc3
@matthiaskrgr
multiple_inherent_impl: make lint adhere to lint message convention
1f17c3b
@matthiaskrgr
pub-enum-variant-names: make lint adhere to lint message convention
4236156
@matthiaskrgr
duration-subsec: make lint adhere to lint message convention
2de290d
@matthiaskrgr
enum-clike-unportable-variant: tweak message a bit (Clike -> C-like)
db390f5
@matthiaskrgr
enum-variant-names: make lint adhere to lint message convention
89591a7
@matthiaskrgr
if_let_some_result: make lint adhere to lint message convention
605e027
@matthiaskrgr
if_not_else: make lint adhere to lint message convention
be3e695
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 11, 2020
@matthiaskrgr
Copy link
Member Author

matthiaskrgr commented Aug 11, 2020 •
edited
Loading

needs a rustup already 😭
rust-lang/rust#75226

yaahc
yaahc approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@yaahc yaahc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't find anything this time, looks great!

@bors r+

clippy_lints/src/int_plus_one.rs
Comment on lines -166 to +167
if let Some(ref rec) = Self::check_binop(cx, kind.node, lhs, rhs) {
Self::emit_warning(cx, item, rec.clone());
if let Some(rec) = Self::check_binop(cx, kind.node, lhs, rhs) {
Self::emit_warning(cx, item, rec);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, I like the cleanup sneaking in the PR

👍

@flip1995 flip1995 added S-waiting-on-bors Status: The marked PR was approved and is only waiting bors and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Aug 11, 2020
@matthiaskrgr
Copy link
Member Author

@bors r=yaahc

@bors
Copy link
Collaborator

bors commented Aug 12, 2020

📌 Commit be3e695 has been approved by yaahc

@bors
Copy link
Collaborator

bors commented Aug 12, 2020

⌛ Testing commit be3e695 with merge c73cf9f...

@bors
Copy link
Collaborator

bors commented Aug 12, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: yaahc
Pushing c73cf9f to master...

@bors bors merged commit c73cf9f into rust-lang:master Aug 12, 2020
@giraffate giraffate mentioned this pull request Aug 13, 2020
Merged
bors added a commit that referenced this pull request Aug 13, 2020
@bors
Auto merge of #5901 - giraffate:add_reference_to_rustc_dev_guide, r=m…
ba363bd 
…atthiaskrgr

Add reference to rustc-dev-guide about lint message

I think it would be better to add lint message convention to documentation. I referred to #5888 and #5893.

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaahc yaahc yaahc approved these changes

Assignees

@yaahc yaahc

Labels
S-waiting-on-bors Status: The marked PR was approved and is only waiting bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@matthiaskrgr @bors @yaahc @rust-highfive @flip1995