Forbid redundant_pattern_matching triggering in macros

[alex-700]

fixes #6065

changelog: forbid redundant_pattern_matching triggering in macros

[rust-highfive]

r? @Manishearth

(rust_highfive has picked a reviewer for you, use r? to override)

[matthiaskrgr]

Mmh, looks like a test is failing:
https://github.com/rust-lang/rust-clippy/pull/6069/checks?check_run_id=1139967161#step:10:138

[Manishearth]

r+ but this should pass tests

[alex-700]

@Manishearth, hm... Is it OK to remove falling test? :) This test is about regression in one of the matches lints and check that message generation inside a macro don't cause ICE. But it seems the forbidding triggerring a lint inside a macro is a common pattern for most of Clippy lints.

[Manishearth]

We don't suppress macros for all of these, so maybe pick a different lint there.

[alex-700]

We don't suppress macros for all of these

But there are a lot of constructions like if in_macro(...) { return; }...

so maybe pick a different lint there.

Sorry, I don't understand, what you mean. I can see two options here:

• lift the check down (only for redundant_pattern_matching)
• remove ice2636.stderr (or even with ice2636.rs (because in this case it checks nothing)).

Which one of them do you think better?

[Manishearth]

I mean that the test can be rewritten to use a different lint. But I think it's also fine to remove, most cases where this ICEs should have a macro check anyway.

[alex-700]

tests failed because of #6067

[bors]

☔ The latest upstream changes (presumably #6071) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

[alex-700]

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

[Manishearth]

@bors r+

[bors]

📌 Commit d4f158f has been approved by Manishearth

[bors]

⌛ Testing commit d4f158f with merge 29b12f2...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 29b12f2 to master...