Revert: or_fun_call should lint calls to const fns with no args
#6077
Conversation
|
r? @yaahc (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Just making sure I understood correctly; |
|
@matthiaskrgr that is my understanding, yep |
|
Ok 👍 @bors r+ |
|
📌 Commit ce83d8d has been approved by |
|
How urgent is this, should this be included in rust-lang/rust#77144 ? (pr was not approved yet) |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
I think this can wait as it's just avoiding false negatives |
Disabling `clippy::or_fun_call` lint for calls to const functions was done with an incorrect understanding that const fns with non arguments would be guaranteed to be const evaluated. This is not the case. See rust-lang/rust-clippy#6077. The revert of this behavior in `clippy::or_fun_call` will land in Rust 1.49.0 due out in a week. This commit removes the pragmas to disable the lint and modifies all callsites to use the lazy `ok_or_else` variant. This commit reverts a change made in #794 and 9a8c14c.
The changes in #5889 and #5984 were done under the incorrect assumption that a
const fnwith no args was guaranteed to be evaluated at compile time. Aconst fnis only guaranteed to be evaluated at compile time if it's inside a const context (the initializer of aconstor astatic).See this zulip conversation for more details on this common misconception.
Given that none of the linted methods by
or_fun_callcan be called in const contexts, the lint should make no exceptions.changelog: [
or_fun_call] lints again calls toconst fnwith no args