Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emit a lint for the suggestion leading to errors in needless_range_loop #6102

Conversation

giraffate
Copy link
Contributor

@giraffate giraffate commented Oct 1, 2020

Fix #5945
Fix #1864

changelog: Don't emit a lint for the suggestion leading to errors in needless_range_loop

@rust-highfive
Copy link

r? @flip1995

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 1, 2020
@flip1995
Copy link
Member

flip1995 commented Oct 1, 2020

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Oct 1, 2020

📌 Commit 0a91fe7 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Oct 1, 2020

⌛ Testing commit 0a91fe7 with merge 8c9800a...

@bors
Copy link
Collaborator

bors commented Oct 1, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 8c9800a to master...

@bors bors merged commit 8c9800a into rust-lang:master Oct 1, 2020
@giraffate giraffate deleted the no_lint_when_invalid_suggestion_in_needless_range_loop branch October 1, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
4 participants