Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not lint float fractions in mistyped_literal_suffixes #6114

Merged
merged 2 commits into from Oct 5, 2020

Conversation

FliegendeWurst
Copy link
Contributor

As suggested in #4706 (comment), the fractional part is now ignored (the integer part is checked instead).

Fixes: #4706

changelog: mistyped_literal_suffixes no longer warns on the fractional part of a float (e.g. 713.23_64)

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 5, 2020
@Manishearth
Copy link
Member

@bors r+

thanks!

@bors
Copy link
Collaborator

bors commented Oct 5, 2020

📌 Commit 428ef36 has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented Oct 5, 2020

⌛ Testing commit 428ef36 with merge 58396a8...

bors added a commit that referenced this pull request Oct 5, 2020
Do not lint float fractions in `mistyped_literal_suffixes`

As suggested in #4706 (comment), the fractional part is now ignored (the integer part is checked instead).

Fixes: #4706

changelog: `mistyped_literal_suffixes` no longer warns on the fractional part of a float (e.g. 713.23_64)
@bors
Copy link
Collaborator

bors commented Oct 5, 2020

💔 Test failed - checks-action_test

@ebroto
Copy link
Member

ebroto commented Oct 5, 2020

@bors retry (rustup)

@bors
Copy link
Collaborator

bors commented Oct 5, 2020

⌛ Testing commit 428ef36 with merge 3239b46...

@bors
Copy link
Collaborator

bors commented Oct 5, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 3239b46 to master...

@bors bors merged commit 3239b46 into rust-lang:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Incorrect mistyped literal suffix on long floats.
5 participants