add manual_ok_or lint

[tnielens]

Implements partially #5923

changelog: add lint manual_ok_or

[rust-highfive]

r? @flip1995

(rust_highfive has picked a reviewer for you, use r? to override)

[flip1995]

Couldn't you implement this lint in the methods module? You wouldn't need the whole method call extraction boilerplate there.

[tnielens]

Couldn't you implement this lint in the methods module? You wouldn't need the whole method call extraction boilerplate there.

In a next iteration, I planned to implement the pattern matching case. See comment about this in the test file.

intOpt match {
  Some(v) => Ok(v),
  None => Err("error"),
}

This doesn't really fit in the methods module, is it?

[flip1995]

Ah ok, I missed that. Then having this in a separate file is fine.

[flip1995]

@bors r+

Thanks!

[bors]

📌 Commit d780f61 has been approved by flip1995

[bors]

⌛ Testing commit d780f61 with merge 225ce5f...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 225ce5f to master...