Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix suggestion to add unneeded space in unused_unit #6247

Merged

Conversation

giraffate
Copy link
Contributor

Fix #6230

changelog: Fix suggestion to add unneeded space in unused_unit

@rust-highfive
Copy link

r? @ebroto

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 27, 2020
clippy_lints/src/unused_unit.rs Outdated Show resolved Hide resolved
@ebroto ebroto added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Oct 27, 2020
@giraffate giraffate force-pushed the fix_suggestion_to_add_space_in_unused_unit branch from dc55009 to 4c58860 Compare October 28, 2020 03:42
@ebroto ebroto added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Oct 30, 2020
@ebroto
Copy link
Member

ebroto commented Nov 4, 2020

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Nov 4, 2020

📌 Commit 4c58860 has been approved by ebroto

@ebroto ebroto removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 4, 2020
@bors
Copy link
Collaborator

bors commented Nov 4, 2020

⌛ Testing commit 4c58860 with merge 0d2f1ae...

@bors
Copy link
Collaborator

bors commented Nov 4, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: ebroto
Pushing 0d2f1ae to master...

@bors bors merged commit 0d2f1ae into rust-lang:master Nov 4, 2020
@giraffate giraffate deleted the fix_suggestion_to_add_space_in_unused_unit branch November 4, 2020 23:41
bors added a commit that referenced this pull request Nov 6, 2020
…_async, r=Manishearth

Fix suggestion to add unneeded space in `manual_async`

Fix a same case as #6247

changelog: Fix suggestion to add unneeded space in `manual_async`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unused_unit adds a space after function declarations
4 participants