Fix FP in indirect needless_collect when used multiple times

[giraffate]

Fix #5991
Fix #6297

changelog: Fix FP in indirect needless_collect when used multiple times

[rust-highfive]

r? @ebroto

(rust_highfive has picked a reviewer for you, use r? to override)

[camsteffen]

It would be nice if the lint still fired when all usages of the collected item are len or is_empty.

[bors]

☔ The latest upstream changes (presumably #6325) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

[ebroto]

It would be nice if the lint still fired when all usages of the collected item are len or is_empty.

I think we can leave that for a future improvement. For now at least we get rid of the false positive.

[ebroto]

@bors r+

Thanks!

[bors]

📌 Commit 8f89108 has been approved by ebroto

[ebroto]

BTW sorry for the long delay in reviewing, I've been deprived of free time for a while

[bors]

⌛ Testing commit 8f89108 with merge 295fe28...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: ebroto
Pushing 295fe28 to master...

[giraffate]

No worries. Thanks for your review!