Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustup #6351

Merged
merged 6 commits into from
Nov 20, 2020
Merged

Rustup #6351

merged 6 commits into from
Nov 20, 2020

Conversation

flip1995
Copy link
Member

r? @ghost

changelog: none

camelid and others added 4 commits November 17, 2020 12:16
This should make Clippy more resilient and will unblock #78343.

This PR is made against rust-lang/rust to avoid the need for a subtree
sync at @flip1995's suggestion in rust-lang#6310.
Fix handling of panic calls

This should make Clippy more resilient and will unblock #78343.

This PR is made against rust-lang/rust to avoid the need for a subtree
sync at ``@flip1995's`` suggestion in rust-lang#6310.

r? ``@flip1995``
cc ``@m-ou-se``
Rustc itself now warns for all cases that triggered this lint.
@flip1995
Copy link
Member Author

@m-ou-se I just noticed 78faaef. Please don't just remove a lint from Clippy in the Rust repo. We have a lengthy process (by design) for removing lints. You can ping us in Rust PRs like this and we can do it for you.

@flip1995
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 20, 2020

📌 Commit dd4e471 has been approved by flip1995

bors added a commit that referenced this pull request Nov 20, 2020
Rustup

r? `@ghost`

changelog: none
@bors
Copy link
Collaborator

bors commented Nov 20, 2020

⌛ Testing commit dd4e471 with merge 1f9aefc...

@bors
Copy link
Collaborator

bors commented Nov 20, 2020

💔 Test failed - checks-action_test

@flip1995
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 20, 2020

📌 Commit 5ee0a40 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Nov 20, 2020

⌛ Testing commit 5ee0a40 with merge 8325d48...

@bors
Copy link
Collaborator

bors commented Nov 20, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 8325d48 to master...

@bors bors merged commit 8325d48 into rust-lang:master Nov 20, 2020
@bors bors mentioned this pull request Nov 20, 2020
@flip1995 flip1995 deleted the rustup branch November 20, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants