Trigger modulo_one lint also on -1.

[mlegner]

Fixes #6321.

changelog: trigger modulo_one lint also on -1

[rust-highfive]

r? @llogiq

(rust_highfive has picked a reviewer for you, use r? to override)

[mlegner]

Question about tests with static constants: Is there a good reason why the lint should not be triggered by those or is this a bug?
If it is a bug, I could either try to fix it in this PR or create an issue for it.

[llogiq]

I don't know the reason. At least filing an issue sounds like a good idea.

[mlegner]

I don't know the reason. At least filing an issue sounds like a good idea.

In general, there seems to be quite some inconsistency with constant/literal testing in clippy. For example, the integer_arithmetic lint also tests for literals but does not do constant folding at all. I will suggest consolidating these to rely on a single constant-comparison function similar to / replacing the is_integer_const function.

[llogiq]

This fails the dogfood test. There's a function in misc.rs with 110 lines. We should probably factor some of the lines out into another function.

[mlegner]

This fails the dogfood test. There's a function in misc.rs with 110 lines. We should probably factor some of the lines out into another function.

I have created a check_binary function that is called in the check_expr function.

[bors]

☔ The latest upstream changes (presumably #6389) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

[llogiq]

Thank you! @bors r+

[bors]

📌 Commit b822632 has been approved by llogiq

[bors]

⌛ Testing commit b822632 with merge a644930...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing a644930 to master...