Moved map_err_ignore to restriction and updated help message #6416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @yaahc |
yaahc
reviewed
Dec 3, 2020
updated help message for the user Co-authored-by: Jane Lusby <jlusby42@gmail.com>
deg4uss3r
force-pushed
the
map_err_restricted
branch
from
dafda36
to
4bc33d3
Compare
|
Updated the test and everything looks good to me now as long as we're happy with the other changes in the MR :) |
|
looks good to me, @ebroto wdyt? |
ebroto
suggested changes
Dec 3, 2020
|
@ebroto done! |
|
📌 Commit 5f821fb has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR moves map_err_ignore lint from
pedanticto therestrictioncategory of lints and updates the help message to give the user an option to ignore the lint by naming the closure variable e.g..map_err(|_ignored| ...changelog: move map_err_ignore to restriction category