Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make needless_update ignore non_exhaustive structs #6464

Merged
merged 2 commits into from
Dec 19, 2020
Merged

make needless_update ignore non_exhaustive structs #6464

merged 2 commits into from
Dec 19, 2020

Conversation

ahouts
Copy link
Contributor

@ahouts ahouts commented Dec 18, 2020

changelog: make needless_update lint ignore non_exhaustive structs

fixes #6323

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 18, 2020
@phansch
Copy link
Member

phansch commented Dec 18, 2020

r? @phansch

@rust-highfive rust-highfive assigned phansch and unassigned flip1995 Dec 18, 2020
phansch
phansch reviewed Dec 18, 2020
View reviewed changes
Copy link
Member

@phansch phansch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your PR, the implementation and test changes look good to me already!

clippy_lints/src/needless_update.rs Outdated Show resolved Hide resolved
@phansch phansch added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Dec 18, 2020
@ahouts ahouts requested a review from phansch December 19, 2020 01:23
@phansch phansch added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Dec 19, 2020
@phansch
Copy link
Member

phansch commented Dec 19, 2020

@bors r+ thanks!

@bors
Copy link
Collaborator

bors commented Dec 19, 2020

📌 Commit a24c6f1 has been approved by phansch

@bors
Copy link
Collaborator

bors commented Dec 19, 2020

⌛ Testing commit a24c6f1 with merge 0718eeb...

@bors
Copy link
Collaborator

bors commented Dec 19, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: phansch
Pushing 0718eeb to master...

@bors bors merged commit 0718eeb into rust-lang:master Dec 19, 2020
@ahouts ahouts deleted the make-needless_update-ignore-non_exhaustive-structs branch December 19, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansch phansch phansch approved these changes

Assignees

@phansch phansch

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

needless_update can be good with ..T::default() for compatibility
5 participants
@ahouts @rust-highfive @phansch @bors @flip1995