Add a new lint ptr_as_ptr
#6542
Conversation
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
flip1995
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #6538) made this pull request unmergeable. Please resolve the merge conflicts. |
which checks for `as` casts between raw pointers without changing its mutability and suggest replacing it with `pointer::cast`.
|
It looks like I was not careful enough about the MSRV stuff. Thanks very much for your help! |
|
@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author |
rustbot
added
S-waiting-on-review
| } | ||
|
|
||
| fn _msrv_1_38() { | ||
| #![clippy::msrv = "1.38"] |
There was a problem hiding this comment.
Oh I didn't know that inner attributes can also be put into functions. I always assumed that they only work on crate and module level. But it makes sense, that they work for every item(-block)-like thing.
|
@bors r+ Thanks! |
|
📌 Commit dfa5d7e has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This PR adds a new lint
ptr_as_ptrwhich checks forascasts between raw pointers without changing its mutability and suggest replacing it withpointer::cast. Closes #5890.Open question: should this lint be
pedanticorstyle? I set itpedanticfor now because the original post suggests using it, but I think the lint also fits well tostyle.changelog: New lint
ptr_as_ptr