Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change env var used for testing Clippy #6575

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

flip1995
Copy link
Member

This changes the variable used for testing Clippy in the internal test
suite:

CLIPPY_TESTS -> __CLIPPY_INTERNAL_TESTS

CLIPPY_TESTS is understandably used in environments of Clippy users,
so we shouldn't use it in our test suite.

changelog: Fix oversight which caused Clippy to lint deps in some environments.

Once again fixes #3874

This changes the variable used for testing Clippy in the internal test
suite:

```
CLIPPY_TESTS -> __CLIPPY_INTERNAL_TESTS
```

`CLIPPY_TESTS` is understandably used in environments of Clippy users,
so we shouldn't use it in our test suite.
@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 11, 2021
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 11, 2021

📌 Commit 547ce0d has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented Jan 11, 2021

⌛ Testing commit 547ce0d with merge 1eed27f...

@bors
Copy link
Collaborator

bors commented Jan 11, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 1eed27f to master...

@bors bors merged commit 1eed27f into rust-lang:master Jan 11, 2021
@flip1995 flip1995 deleted the stop_linting_deps branch January 11, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error reading Clippy's configuration file...
4 participants