or_fun_call: fix suggestion for or_insert(vec![])
#6790
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
Applies for `std::collections::hash_map::Entry` and `std::collections::btree_map::Entry`
Example:
Previously, for the following code:
`let _ = hash_map.entry("test".to_owned()).or_insert(vec![]);`
clippy would suggest to use:
`or_insert_with(vec![])`, which causes a compiler error (E0277).
Now clippy suggests:
`or_insert_with(Vec::new)`
|
@bors r+ thanks! |
|
📌 Commit 2f0e9f7 has been approved by |
or_fun_call: fix suggestion for `or_insert(vec![])` fixes #6748 changelog: or_fun_call: fix suggestion for `or_insert(vec![])` on `std::collections::hash_map::Entry` or `std::collections::btree_map::Entry`
|
@bors r+ thanks! |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 2f0e9f7 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
fixes #6748
changelog: or_fun_call: fix suggestion for
or_insert(vec![])onstd::collections::hash_map::Entryorstd::collections::btree_map::Entry