Fix manual_map false positives
#6801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @phansch (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Should probably also revert #6796 |
Fix `manual_map`: don't lint when `return`, `break`, and `continue` are used.
Jarcho
force-pushed
the
manual_match_fix
branch
from
4616e9c
to
09a827a
Compare
|
There is also a bug where macros are expanded in the suggestion (for example, if you map like this: You might be able to fix this by using 5d48b91#diff-91a6b641836ec4d791eef672694e2e955b77f9b9e287fcbaacbdb83b3734acabL190 |
Jarcho
force-pushed
the
manual_match_fix
branch
from
4f2559c
to
a3278a1
Compare
|
@bors r+ thanks! |
|
📌 Commit 2c485e3 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #6795
fixes: #6797
fixes: #6811
fixes: #6819
changelog: Fix false positives for
manual_mapwhenreturn,break,continue,yield,await, and partially moved values are used.changelog: Don't expand macros in suggestions for
manual_map