Write literal suggestion #6821
Merged
Write literal suggestion #6821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Jarcho
force-pushed
the
write_literal_suggestion
branch
from
7537128
to
a15f9ee
Compare
flip1995
reviewed
Mar 15, 2021
flip1995
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #6914) made this pull request unmergeable. Please resolve the merge conflicts. |
flip1995
approved these changes
Mar 16, 2021
Don't lint on a mixture of raw and regular strings Fix spans in format strings
Jarcho
force-pushed
the
write_literal_suggestion
branch
from
b130ce0
to
6946cc1
Compare
Jarcho
force-pushed
the
write_literal_suggestion
branch
from
6946cc1
to
d45873b
Compare
|
@bors r+ Thanks! |
|
📌 Commit d45873b has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #6768
changelog: Add suggestion to
write_literalandprint_literallintschangelog: Change
use_debugto point only at the format string