disable upper_case_acronyms for pub items - enum edition #6981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
matthiaskrgr
changed the title
matthiaskrgr
force-pushed
the
6803_take_2
branch
from
51891ab
to
ca7e955
Compare
|
@bors r+ Thanks! |
|
📌 Commit ca7e955 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6803 (again... 😅 )
My previous fix did not work for enums because enum variants were checked separately in the
check_variantfunction but it looks like we can't use that because we can't tell if the enum the variants belong to is declared as public or not (it always saidInheritedfor me)I went and special-cased enums and iterated over all the variants "manually", but only, if the enums is not public.
changelog: fix upper_case_acronyms still firing on public enums (#6803)