Improve expl_impl_clone_on_copy
#6993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
You're really on a roll. 😀 Thank you! @bors r+ |
|
📌 Commit 5b2fb8c has been approved by |
bors
added a commit
that referenced
this pull request
Mar 28, 2021
Improve `expl_impl_clone_on_copy` fixes: #1254 changelog: Check to see if the generic constraints are the same as if using derive for `expl_impl_clone_on_copy`
|
💔 Test failed - checks-action_dev_test |
Check to see if the generic constraints are the same as if using derive
|
@bors r+ |
|
📌 Commit 879fa5c has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
bors
added a commit
that referenced
this pull request
Aug 17, 2021
Update docs for `expl_impl_clone_on_copy` The known issue was fixed in #6993. I missed updating the docs then, so it's happening now. changelog: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1254
changelog: Check to see if the generic constraints are the same as if using derive for
expl_impl_clone_on_copy