Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow missing panics doc if the panics occur only when debug-assertions is specified #6996

Merged
merged 2 commits into from
Mar 29, 2021

Conversation

Y-Nak
Copy link
Contributor

@Y-Nak Y-Nak commented Mar 29, 2021

fixes #6970

changelog: missing_panics_doc: Allow missing panics doc if the panics occur only when debug-assertions is specified.

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 29, 2021
@Y-Nak Y-Nak changed the title Missing panics doc Allow missing panics doc if the panics occur only when debug-assertions is specified Mar 29, 2021
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 29, 2021

📌 Commit 31afdfc has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented Mar 29, 2021

⌛ Testing commit 31afdfc with merge 0e06b3c...

@bors
Copy link
Collaborator

bors commented Mar 29, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 0e06b3c to master...

@bors bors merged commit 0e06b3c into rust-lang:master Mar 29, 2021
@Y-Nak Y-Nak deleted the missing_panics_doc branch March 29, 2021 15:21
lopopolo added a commit to artichoke/rand_mt that referenced this pull request Sep 4, 2021
lopopolo added a commit to artichoke/intaglio that referenced this pull request Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing_panics_doc is issued for debug_assert!
4 participants