Clippy going dark: Adding a dark theme to Clippy's lint list #7030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Thank you! @bors r+ |
|
📌 Commit e25b106 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
Well... I don't know why, but it seems like the theme isn't working on the site after the merge 😕 here. I'll try to see if the fix is easy or submit a revert PR until the problem is figured out -.- |
|
It turns out that |
bors
added a commit
that referenced
this pull request
Apr 5, 2021
Quick fix for the updated website theaming to access the correct css files This fixes a problem from #7030 that the service used to access css files was blocked by GitHub pages due to `SSL_ERROR_BAD_CERT_DOMAIN`. The css file loading worked fine during local development. The browser probably disabled some security options due to the local address. This fix works locally and should also work online as it references the direct css files used by the [mdBook User Guide](https://rust-lang.github.io/mdBook/index.html) the disadvantage of this is that refactorings within the mdBook project can have effects on the theme loading of Clippy. This PR is therefor more meant as a quick fix until I find a better solution. I've tested these changes using the page editor in the browser and can now confirm that they work :) changelog: none r? `@llogiq`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the MdBook color themes to the lint list of Clippy. Well at least an adaption of these themes.
Here are some beautiful screenshots:
light theme
Rust theme
Coal theme
Navy theme
Ayu theme
The theme is also stored in the browser to ensure that the next session applies the theme and doesn't burn your eyes out.
cc: @matthiaskrgr
Closes #6877
changelog: Clippy's lint list now supports themes