Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate filter_map #7059

Merged
merged 1 commit into from
Apr 11, 2021
Merged

Deprecate filter_map #7059

merged 1 commit into from
Apr 11, 2021

Conversation

camsteffen
Copy link
Contributor

Since #6591, filter_map does not even lint filter().map(). The cases that are still linted make no sense IMO. So this just removes/deprecates it.

changelog: Deprecate filter_map lint

Closes #3424
Fixes #7050

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 9, 2021
tests/ui/deprecated.stderr Outdated Show resolved Hide resolved
@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Apr 11, 2021

📌 Commit a45faf6 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Apr 11, 2021

⌛ Testing commit a45faf6 with merge a6b514c...

@bors
Copy link
Collaborator

bors commented Apr 11, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing a6b514c to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filter_map suggestion on flat_map is wrong filter_map docs woefully incomplete
4 participants