Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single_match #7093

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Fix single_match #7093

merged 1 commit into from
Apr 16, 2021

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Apr 16, 2021

fixes: #7038
changelog: Don't suggest an equality check for types which don't implement PartialEq in single_match

Check for `PartialEq` in addition to `StructuralPartialEq` before suggesting `==`
@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 16, 2021
@llogiq
Copy link
Contributor

llogiq commented Apr 16, 2021

Thank you! @bors r+

@bors
Copy link
Collaborator

bors commented Apr 16, 2021

📌 Commit 9a55c0c has been approved by llogiq

@bors
Copy link
Collaborator

bors commented Apr 16, 2021

⌛ Testing commit 9a55c0c with merge ddc2598...

@bors
Copy link
Collaborator

bors commented Apr 16, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing ddc2598 to master...

@bors bors merged commit ddc2598 into rust-lang:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

single_match gives bad suggestion
4 participants