fix ice when checking rustc libstd #7140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thread 'rustc' panicked at 'index out of bounds: the len is 0 but the index is 0', src/tools/clippy/clippy_lints/src/matches.rs:1595:53 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace I don't have a minimised testcase because I don't have time to reduce libstd down to a few lines right now.
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Good catch! @bors r+ |
|
📌 Commit 572c405 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
camsteffen
reviewed
Apr 29, 2021
| @@ -1590,9 +1590,9 @@ fn is_none_arm(cx: &LateContext<'_>, arm: &Arm<'_>) -> bool { | |||
| // Checks if arm has the form `Some(ref v) => Some(v)` (checks for `ref` and `ref mut`) | |||
| fn is_ref_some_arm(cx: &LateContext<'_>, arm: &Arm<'_>) -> Option<BindingAnnotation> { | |||
| if_chain! { | |||
| if let PatKind::TupleStruct(ref qpath, pats, _) = arm.pat.kind; | |||
| if let PatKind::TupleStruct(ref qpath, [first_pat, ..], _) = arm.pat.kind; | |||
There was a problem hiding this comment.
This was puzzling me at first but now I believe the reproduction case is Some(..).
Also FWIW, this could be [pat].
steffahn
added a commit
to steffahn/rust
that referenced
this pull request
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have a minimised testcase because I don't have time to reduce libstd down to a few lines right now.
changelog: fix index out of bounds access when checking rustc libstd