Early return from LintPass registration when collecting metadata #7253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This speeds up the metadata collection by 2-2.5x on my machine. During metadata collection other lint passes don't have to be registered, only the lints themselves.
flip1995
commented
May 20, 2021
| { | ||
| if std::env::var("ENABLE_METADATA_COLLECTION").eq(&Ok("1".to_string())) { | ||
| store.register_late_pass(|| box utils::internal_lints::metadata_collector::MetadataCollector::new()); | ||
| return; |
There was a problem hiding this comment.
This line is the only actual change in this PR.
Everything else is just moving the register_*_pass calls below the group registration.
|
LGTM! This change sped up the collection on my machine about 2x as well. @bors r+ |
|
@xFrednet: 🔑 Insufficient privileges: Not in reviewers |
|
Well, @flip1995 could you merge the PR with |
|
@bors r=xFrednet |
|
📌 Commit 7304829 has been approved by |
23 tasks
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up the metadata collection by 2-2.5x on my machine. During
metadata collection other lint passes don't have to be registered, only
the lints themselves.
cc #7172
r? @xFrednet
changelog: none