Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix allow on some statement lints #7282

Merged
merged 1 commit into from
May 27, 2021
Merged

Conversation

camsteffen
Copy link
Contributor

changelog: Fix #[allow(..)] over statements for [needless_collect], [short_circuit_statement] and [unnecessary_operation]

Fixes #7171
Fixes #7202

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 27, 2021
@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented May 27, 2021

📌 Commit f3e77a4 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented May 27, 2021

⌛ Testing commit f3e77a4 with merge 8066f83...

@bors
Copy link
Collaborator

bors commented May 27, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 8066f83 to master...

@bors bors merged commit 8066f83 into rust-lang:master May 27, 2021
@camsteffen camsteffen deleted the lint-stmt-expr branch July 8, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't allow a single needless_collect Can't disable no_effect
5 participants